Skip to content

fix(wren-ui): correct generate instruction request payload#1482

Merged
wwwy3y3 merged 1 commit intomainfrom
fix/instruction
Mar 28, 2025
Merged

fix(wren-ui): correct generate instruction request payload#1482
wwwy3y3 merged 1 commit intomainfrom
fix/instruction

Conversation

@onlyjackfrost
Copy link
Copy Markdown
Contributor

@onlyjackfrost onlyjackfrost commented Mar 28, 2025 •
edited by coderabbitai bot
Loading

correct generate instruction request payload:

  • project_id should be at the first layer

Summary by CodeRabbit

  • Refactor
    • Restructured the payload sent to the backend to simplify communication, shifting key identifiers to a higher level for more efficient data handling.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 28, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The change updates the generateInstruction method in the WrenAIAdaptor class to modify how the API request body is constructed. Instead of including project_id in each instruction object, it is now extracted once from the first item and consolidated at the body level. Additionally, the axios API call has been simplified to directly use the new body structure.

Changes

File Change Summary
wren-ui/src/apollo/server/adaptors/wrenAIAdaptor.ts Modified generateInstruction to consolidate the project_id into the body object (extracted from the first input element), enclosed the instructions array in an object, and simplified the axios.post call.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant WrenAIAdaptor
    participant API
    Client->>WrenAIAdaptor: Call generateInstruction(input array)
    WrenAIAdaptor->>WrenAIAdaptor: Extract project_id from first element
    WrenAIAdaptor->>WrenAIAdaptor: Build request body { instructions: [...], project_id }
    WrenAIAdaptor->>API: axios.post(requestBody)
    API-->>WrenAIAdaptor: API Response
    WrenAIAdaptor-->>Client: Return Response
Loading

Suggested reviewers

  • fredalai

Poem

In the code garden, I hop with delight,
Restructuring calls and setting data aright;
The project ID now sits at a central place,
As axios posts with simplicity and grace;
A bunny's cheer echoes in every byte! 🐰

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 23bc21d and 378d2b6.

📒 Files selected for processing (1)
  • wren-ui/src/apollo/server/adaptors/wrenAIAdaptor.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wwwy3y3 wwwy3y3 merged commit 8dc5ccb into main Mar 28, 2025
5 of 6 checks passed
@wwwy3y3 wwwy3y3 deleted the fix/instruction branch March 28, 2025 06:42
wwwy3y3 pushed a commit that referenced this pull request Apr 1, 2025
@onlyjackfrost @wwwy3y3
fix(wren-ui): correct generate instruction request payload (#1482)
cb245a0
andreashimin pushed a commit that referenced this pull request Apr 1, 2025
@onlyjackfrost @andreashimin
fix(wren-ui): correct generate instruction request payload (#1482)
fe6d1ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wwwy3y3 wwwy3y3 wwwy3y3 approved these changes

Assignees

No one assigned

Labels

wren-ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@onlyjackfrost @wwwy3y3